Add android-key attestation format support - #2749
Merged
Merged
Conversation
Add a new attestationFormat for ACME device-attest-01 challenge to support Android attestation (android-key) as defined by WebAuthn and modify by RFC (sig use key authorization). The implementation involve adding a CRL. ACME provider support a new configuration key called RootCRLs (rootCRLs in json). When 'android-key' is specified in attestationFormat and the list is not provided by the configuration, the list will be populated and updated automatically based on the validation implementation procedure. Other ACME challenge could use IsRootRevoked and RootCRLs in the future independantly to android-key or device-attest-01 challenge.
The x5c verification now also checks the leaf to not have been revoked, and the Android Key Attestation extension is searched for in reverse order.
github-actions
Bot
added
the
needs triage
areed
reviewed
Jul 22, 2026
areed
left a comment
areed
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Should we skip the CRL check when not using the Android roots?
hslatman
force-pushed
the
herman/android
branch
2 times, most recently
from
July 22, 2026 20:50
a995c1c to
66ca9bc
Compare
areed
reviewed
Jul 22, 2026
| // AndroidKeyCRLChecker references an implementation of [androidkey.CRLChecker] | ||
| // that is responsible for checking revoked Android Key Attestation certificate | ||
| // serial numbers. | ||
| AndroidKeyCRLChecker androidkey.CRLChecker |
Contributor
There was a problem hiding this comment.
It looks like this is always going to be nil
Member
Author
There was a problem hiding this comment.
Yes, that's the case for open source. In hosted we'll inject a custom checker so that we can keep a single shared CRL for just the Google roots.
EDIT: missed a level of passing it around: c4ca1a6.
areed
approved these changes
Jul 23, 2026
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #2322.