Build fixes for the 3.y.z branch#2515
Merged
Merged
Conversation
Contributor
Author
|
/cc @jmartisk |
Member
|
Thanks a lot!! For the stork issue, smallrye/smallrye-stork#1201 now says it's fixed in 2.7.10, which we can use in 2.x |
jmartisk
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to work on one issue, but there seem to be few issues regarding the build, so this PR attempts to fix them.
5f08e6a and bdeaa69 might be worth backporting to 2.x.
Regarding the b6611d4, it contains the fix for the smallrye/smallrye-stork#1201
Which was not backported 2.x, so either, a) we will ask for backport, or b) we would just use SR Stork 3.x instead, which I think is fine since it aligns with the Vertx 5 migration of SR GQL 3.x.