Prune dominated duplicate integer overflow checks#825
Open
shaobo-he wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #751.
This implements a concrete dependency-analysis step for integer overflow checking.
When IntegerOverflowChecker lowers llvm.{s,u}{add,sub,mul}.with.overflow intrinsics under --check=integer-overflow, it now tracks checked operations by signedness, opcode, bitwidth, and SSA operands. If an identical checked operation already dominates a later one, the later overflow assertion is skipped and the later intrinsic overflow flag is replaced with false.
This reduces redundant overflow assertions while preserving code that observes the overflow flag. Add/mul keys are canonicalized for commuted operands; sub remains ordered.
The earlier assert-assume behavior is kept for emitted checks: after __SMACK_check_overflow(flag), SMACK emits __VERIFIER_assume(!flag), making the proven no-overflow fact available downstream.
The optimization is deliberately guarded by the existing check condition:
Verification: