Skip to content

WIP: Initiating and receiving drag and drop using winit API #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eira-fransham wants to merge 8 commits into
base: feature/winit-0.31
Choose a base branch
from
Open

WIP: Initiating and receiving drag and drop using winit API #11966

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c0ef19
WIP: winit backend Drop support
ogoffart May 22, 2026
f3512f7
[autofix.ci] apply automated fixes
autofix-ci[bot] May 22, 2026
8d33b23
WIP: Still-buggy implementation of initiating/receiving external drag…
eira-fransham Jun 4, 2026
c8dc052
Fix bugs in dnd
eira-fransham Jun 4, 2026
b937994
Fix mixed winit versions on Linux
eira-fransham Jun 4, 2026
8f5daef
Fix rebuilding data transfer, fix image display
eira-fransham Jun 8, 2026
b6c58cf
Fix clippy warnings
eira-fransham Jun 8, 2026
c95da17
Fix dragging items out and then back in to the same window, fix hidin…
eira-fransham Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions api/cpp/cbindgen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ fn gen_corelib(
"Rect",
"SortOrder",
"BitmapFont",
"DataTransferOpaque",
]
.iter()
.chain(items.iter())
Expand Down Expand Up @@ -579,7 +578,6 @@ fn gen_corelib(
),
(
vec![
"DataTransferOpaque",
"slint_data_transfer_init_default",
"slint_data_transfer_drop",
"slint_data_transfer_clone",
Expand Down
4 changes: 1 addition & 3 deletions api/cpp/include/private/slint_data_transfer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,8 @@ struct DataTransfer
}

private:
/// Storage matching the size and alignment of `DataTransfer` in `i_slint_core`.
/// All operations on this field go through the `slint_data_transfer_*` FFI functions;
/// it is never inspected directly from C++. See
/// `i_slint_core::data_transfer::ffi::DataTransferOpaque`.
cbindgen_private::types::DataTransferOpaque _inner;
cbindgen_private::types::DataTransfer _inner;
};
}
4 changes: 3 additions & 1 deletion api/rs/slint/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ path = "lib.rs"

[features]

default = ["std", "backend-default", "renderer-femtovg", "renderer-software", "accessibility", "compat-1-2"]
# HACK

@ogoffart ogoffart Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this hack? accessibility should already be disabled in the winit/build.rs in that branch.

@eira-fransham eira-fransham Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I checked and this isn't necessary on Linux, but it's required to build on macOS.

# default = ["std", "backend-default", "renderer-femtovg", "renderer-software", "accessibility", "compat-1-2"]
default = ["std", "backend-default", "renderer-femtovg", "renderer-software", "compat-1-2"]

## Mandatory feature:
## This feature is required to keep the compatibility with Slint 1.2
Expand Down
Loading
Loading