feat(routing): make request path decoding configurable#3451
Open
ErfanMomeniii wants to merge 1 commit into
Open
feat(routing): make request path decoding configurable#3451ErfanMomeniii wants to merge 1 commit into
ErfanMomeniii wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @odan, please review it. |
|
coverage: 96.794% (+0.03%) from 96.768% — ErfanMomeniii:decode-path-optional into slimphp:5.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The routing middleware decodes the request path with
rawurldecode()before dispatch, which collapses%2Finto/and prevents routes like/something/{magic}/{foo}from matching/something/magic/foo%2Fbar. This PR adds a decodePath parameter onApp::addRoutingMiddleware();passing false skips that decoding, so encoded reserved characters survive routing and reach handlers untouched. The default remains true, so existing applications are unaffected.Fixes #3374