Ensure that Nyholm PSR17 factory is fully available#3426
Merged
Conversation
The Nyholm PSR7 packages are split into a server package, and a client package. Both are required for the NyholmPsr17Factory to be able to return an instance of the `ServerRequestCreator` class.
Contributor
|
Thanks for the PR. It looks like coveralls.io is not available at the moment: https://status.coveralls.io/ |
|
coverage: 99.454% (+0.002%) from 99.452% — andrewnicols:nyholmServerWithoutClient into slimphp:4.x |
Contributor
Author
|
Hi @odan, Coveralls is back up - any chance of a review? Thanks |
Contributor
|
Hi @andrewnicols Please check this issue: https://github.com/slimphp/Slim/actions/runs/22377160579/job/65296930027?pr=3426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently use Guzzle for PSR17/PSR7.
We're also now adding in open-telemetry (
open-telemetry/exporter-otlp), which makes use ofnyholm/psr7-server, but it does not depend onnyholm/psr7.As a result we now have the Nyholm server request creator, but not the response Factory class.
\Slim\Factory\Psr17\Psr17Factory::isServerRequestCreatorAvailable()returns a truthy value for Nyholm, but whengetServerRequestCreator()is called, it errors out.The Nyholm PSR7 packages are split into a server package, and a client package. Both are required for the NyholmPsr17Factory to be able to return an instance of the
ServerRequestCreatorclass.This change amends the
NyholmPsr17Factory:: isServerRequestCreatorAvailable()method to also check if the response factory class provided by the client package is available.I can't think of a way of testing this with automated testing. For manual testing you can install
nyholm/psr7-serverwithoutnyholm/psr7-- before this change we were hitting an exception.