fix: await Cypress after-run cleanup#2669
Merged
antfu merged 1 commit intoJul 14, 2026
Merged
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after:runlifecycle callbacknullresult unchangedProblem
stopBasePathServer()intentionally resolves tonullbecause Cypress task handlers must return a defined value. Passing that promise through directly makes theafter:runcallback returnPromise<null>, but Cypress types accept onlyvoid | Promise<void>. The root typecheck therefore reportsTS2769atcypress.config.ts.Awaiting the helper inside an async callback preserves the task contract while making the lifecycle callback resolve to
void.Validation
pnpm exec tsc --ignoreConfig --noEmit --skipLibCheck --moduleResolution bundler --module esnext --target esnext --types node,cypress --esModuleInterop cypress.config.ts cypress/basePathServer.tspnpm exec eslint cypress.config.tsgit diff --checkpnpm typecheckno longer reports the Cypress overload error; the remaining four errors are the existing VitePress declaration and duplicatemarkdown-exitdependency errors onmain