fix: use import.meta.env.DEV instead of __DEV__ for mode detection#2666
Open
ocean-sudo wants to merge 1 commit into
Open
fix: use import.meta.env.DEV instead of __DEV__ for mode detection#2666ocean-sudo wants to merge 1 commit into
ocean-sudo wants to merge 1 commit into
Conversation
__DEV__ is not auto-defined by Vite 8 when NODE_ENV=production is set, causing the dev server to render a blank page. Replace it with import.meta.env.DEV which correctly reflects Vite dev/prod mode regardless of NODE_ENV. Fixes slidevjs#2665
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2665 — dev server renders blank page when
NODE_ENV=productionis set.Root Cause
packages/client/env.tsuses__DEV__to detect dev mode, but__DEV__is not auto-defined by Vite 8 whenNODE_ENV=productionis present in the environment.Fix
Replace the non-standard
__DEV__with Vite's built-inimport.meta.env.DEV:import.meta.env.DEVcorrectly reflects Vite's mode (dev server vs build) regardless ofNODE_ENV.