Skip to content

chore(deps): make express an optional peer dependency #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benmccann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): make express an optional peer dependency #2815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@slack/types": "^2.20.0",
"@slack/web-api": "^7.14.1",
"axios": "^1.12.0",
"express": "^5.0.0",
"path-to-regexp": "^8.1.0",
"raw-body": "^3",
"tsscmp": "^1.0.6"
Expand All @@ -74,6 +73,12 @@
"typescript": "5.3.3"
},
"peerDependencies": {
"@types/express": "^5.0.0"
"@types/express": "^5.0.0",
"express": "^5.0.0"
},
"peerDependenciesMeta": {
"express": {
"optional": true
}
Comment on lines +79 to +82
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since express is currently a dependency we can't make it an "optional" peerDependency since some users may be relying on it to transitively import express in their projects, this would cause a breaking change

Removing this section would make express a required peer-dependency (non-breaking change), this will allow users to explicitly exclude it from their projects with npm install --omit peer

}
}