chore(pkg): tag c1/c2 net+rte package comments with c<layer>-<domain> [HOLD]#3410
Draft
0pcom wants to merge 1 commit into
Draft
chore(pkg): tag c1/c2 net+rte package comments with c<layer>-<domain> [HOLD]#34100pcom wants to merge 1 commit into
0pcom wants to merge 1 commit into
Conversation
522bb75 to
ce84311
Compare
Overlays the skywire package taxonomy (../kcg-game-standards-golang/ domains-golang.txt) onto the net-domain mesh spine: each file's existing '// Package <name> <path>' doc line gains a trailing c<layer>-<domain>-<system> tag, e.g. '// Package transport pkg/transport/manager.go c2-net-transport'. Doc-comment only — no code, no imports; package names stay idiomatic. Keeps revive package-comments happy and is greppable (grep -rn 'c[0-9]-net-' pkg/). Systems this pass: net.dmsg (dmsg/dmsgc c1), net.transport (skyquic/transport/ transport-setup/skyudpbridge/stunserver/tcpproxy c1|c2), net.routing (routing c1; router/rfclient/skyroute c2), net.monitor (networkmonitor c2). 91 files. go build ./... + gofmt + golangci-lint clean. Remaining net systems (cxo, discovery) + app/vis/com domains are a mechanical follow-up. Domain set = 3 functional domains (net/app/vis) + a com c0 base, with the detail in SYSTEMS (per Synth: 1-3 domains, push detail into systems).
ce84311 to
453e0c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT / HOLD — do not merge yet (pending sign-off on the domain/layer convention with Synth).
Overlays the skywire package taxonomy onto the mesh-spine packages: each file's existing
// Package <name> <path>doc line gains a trailingc<layer>-<domain>tag, e.g.// Package transport pkg/transport/manager.go c2-net.transport.Manager).package-commentshappy (still leads with "Package ").grep -rn 'c[0-9]-net\|c[0-9]-rte' pkg/.Scope (this pass):
net(dmsg/dmsgc/skyquic = c1; transport/transport-setup/skyudpbridge/stunserver/tcpproxy/networkmonitor = c2) +rte(routing = c1; router/rfclient/skyroute = c2). 91 files.go build ./...+ gofmt + golangci-lint all clean.Taxonomy + the full 8-domain mapping (com/net/rte/cxo/dsc/app/vis/rwd) and the rationale for the doc-comment convention (vs the compiler/linter rejecting a name prefix) live in the standards derivation doc set. Remaining domains are a mechanical follow-up with the same tagger.