List: make the reorder drag visible on dark backgrounds

[humbuckr]

Fixes the problem reported in #517.

The problem

RenderReorderableItem styles the dragged row with Modifier.shadow(8.dp) and
nothing else. A shadow expresses elevation by darkening what is around the
row — so over a dark page it expresses nothing. On #000 there is nothing left
to darken, and the row under your finger is pixel-identical to the rows at rest.
A reorder on a dark-themed app has no visible affordance at all.

The change

Draw a tonal lift alongside the shadow, which is Material's own answer for
elevation on dark surfaces: the surface itself gets lighter.

let dragTint = MaterialTheme.colorScheme.onSurface.copy(alpha: Float(0.10))
itemModifier = itemModifier.drawWithContent {
    drawContent()
    drawRect(color: dragTint)
}

Two choices worth flagging for review:

• Over the content, not behind it. A list row almost always paints its own
  background, so a tint drawn behind it would never be seen.
• onSurface, not a fixed colour, so it follows the scheme in both
  directions — lighter on dark themes, darker on light ones. Light themes keep
  the shadow they already had and gain a subtle press-like tint; dark themes gain
  the only feedback they can receive.

Happy to put it behind an environment hook in the shape of material3Ripple
instead, if you would rather this be opt-in than a default.

Why apps cannot work around it

• onMove is invoked from onDragEnd, so SwiftUI code learns about the move
  only on drop.
• Modifier.detectReorderAfterLongPress claims the long press, so an app's own
  .onLongPressGesture(..., onPressingChanged:) on the row never fires.
• And that callback is one-way regardless: onLongPressChange() calls
  onChanged(true) and nothing ever calls it with false.

Testing

Built and run on device: Android 14, Samsung SM-A326U (Dimensity 700), release
build, a 24-row playlist on a #121212 page with #252525 rows. Before the
patch, dragging produced no visible change; after it, the dragged row lifts while
held and returns to rest on drop. Light-theme rendering unchanged apart from the
new tint.

[cla-bot]

Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @humbuckr on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file

[marcprux]

This looks useful?

Could you post a before and after screenshot of a row being dragged with this effect?

[humbuckr]

Hey Marc - I am new to Git and skip-ui. i dont have a screenshot from before now. sorry.

…

On Mon, Aug 31, 2026 at 7:12 AM marcprux ***@***.***> wrote: *marcprux* left a comment (skiptools/skip-ui#518) <#518 (comment)> This looks useful? Could you post a before and after screenshot of a row being dragged with this effect? — Reply to this email directly, view it on GitHub <#518?email_source=notifications&email_token=ABF5R7G2X32PJAJZXDBYQPT5MWBWTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBXHE3DANBVGM2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5479604534>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABF5R7DWHMHAEY2PETN6YIT5MWBWTAVCNFSNUABFKJSXA33TNF2G64TZHM3DMOJZGUZDQNZVHNEXG43VMU5TKMRZGYYTCOJYGAZKC5QC> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/ABF5R7HDMBJ4MLCNSBUIXBD5MWBWTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBXHE3DANBVGM2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/ABF5R7FJ4PJDVAUMCG2J6CD5MWBWTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBXHE3DANBVGM2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>