Repository navigation
J2: completion-result validator, replay redaction, must_refuse vectors - #32
Merged
Merged
Conversation
- completion.ts: validateCompletionResult (DEFAULT_SECRET_MEMBERS), validateMatchResult (closed set, openid4x 3.3), REPLAY_SECRET_MEMBERS, redactedMembers, splitReplaySecrets mirroring go-wmp SplitReplaySecrets (escaped names, duplicate names, case variants, existing redacted_members all refused; verbatim values kept). Errors never echo a member value. - Peer refuses a non-conforming wmp.flow.complete: not delivered, the flow ends with a synthesized -32602 flow.error; validateCompletions: false opts out. redacted_members is exposed as unrecoverable via redactedMembers(). - Harness executes every flow-lifecycle completion/match vector including all must_refuse ones, and the expected_replay vectors. select_credentials must_refuse vectors are listed as pending until J5. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
There was a problem hiding this comment.
🟡 Changes recommended
Match completions can bypass closed-set privacy validation, while generic validation can silently drop rejected completions without notifying the receiving handler of terminal failure.
2 open issues
What changed in this PR
This J2 parity update builds on J1’s vector harness with OpenID4x result validators, replay-secret redaction, and default completion checks in Peer.
Changes:
- Adds completion and match validators plus helpers for withholding replay secrets.
- Adds configurable completion refusal with sanitized error callbacks.
- Exercises completion/match refusal and replay vectors, leaving select-credentials checks pending for J5.
| File | Description |
|---|---|
test/conformance.test.ts |
Executes flow-result refusal and expected-replay vectors. |
test/completion.test.ts |
Tests validators, replay redaction, and Peer refusal behavior. |
src/peer.ts |
Adds completion validation options and synthesized failure delivery. |
src/index.ts |
Exports validators, replay helpers, constants, and types. |
src/completion.ts |
Implements result validation and strict replay-secret splitting. |
Review effort: Balanced
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
…eric validator - Peer records the flow type (and for match the DCQL query ids) when a flow starts, outgoing or incoming, and checks a completion by it: a match flow's result is the closed set (validateMatchResult), including a completion with no result; never selected by members of the result. - A non-conforming completion is refused before opts.validator runs, so a validator rejecting the message no longer drops it silently; authorization still comes first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
…ty, envelope - The flow type / query-id context is recorded in Peer.call for every outgoing flow.start (convenience method and profiles alike) and for incoming starts. - A start under an active flow_id is refused (-32602) so it cannot replace the first flow's context; a start that fails (handler error, error response, timeout) leaves nothing recorded. flow.cancel frees the id. - The context of an unfinished flow is never evicted: a new start beyond 4096 active flows is refused (-31007). - The early result-refusal path applies only to a completion with the basic envelope (flow_id and a wmp object with a version); anything else is left to the configured validator. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
There was a problem hiding this comment.
🟡 Changes recommended
Completed incoming flows and successfully cancelled outgoing flows leave stale recordedFlows entries, causing new flows to be rejected after 4,096 finished flows despite none remaining active.
1 open issue
4 resolved since last review
Review effort: Balanced
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
Peer.notify (shared by flowComplete, flowError and profiles) releases the validation context of a flow after a successful complete/error send, and a successful flow.cancel response in Peer.call releases it too, so finished flows no longer accumulate toward the active-flow limit. Tests run 4100 sequential flows through each path. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
…ns, sorted markers, session scope - Finished, refused and cancelled flows are remembered (terminalSeen, never evicted, no active slot): a further terminal message for them is ignored instead of being judged by the general rules, so a refused match completion sent twice, or a claim-bearing repeat after a normal end, cannot reach the handler. A restarted id is judged afresh. - A completion without the basic envelope is not delivered when no schema validator is configured to judge it. - redacted_members must be in alphabetical order (profile 3.1.4). - The flow contexts and markers are cleared when the session is closed or replaced (local and incoming create/close, resume of another session) and kept when the same session is resumed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
Only flows this peer knew (recorded as active) are remembered when they end; a terminal message for a flow it never saw start is delivered as before but not remembered, so a remote peer cannot grow the history with fresh ids. The history is capped at 65536 finished flows per session and is never evicted: at the cap new flows are refused (-31007) until the session is renewed, while an id already in the history can still be reused. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
There was a problem hiding this comment.
🔵 Needs a closer look
Critical flow-lifecycle races and session-tracking gaps require human assessment because they can disrupt replacement flows and allow late terminal messages through validation.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
An incoming create records the session id its handler returned and an incoming resume installs the resumed session, so a session.close naming it clears the flow contexts and markers, a resume of a different session drops the old state (also when none was held) and a resume of the same session keeps it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
The peer no longer reports (peer.session) or addresses (wmpMeta) a session that the remote side closed, matching closeSession(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parity chunk J2, stacked on #31 (base: j1-harness; retarget to main when #31 merges).
validateCompletionResult(result, secretMembers?),validateMatchResult,DEFAULT_SECRET_MEMBERS,REPLAY_SECRET_MEMBERS,redactedMembers,splitReplaySecrets(mirror of go-wmp SplitReplaySecrets; strict scanner: escaped names, duplicate names, case variants refused).Peerrefuses non-conforming completions (not delivered; synthesized -32602 flow.error, no member echoed).validateCompletions: falseopts out.redacted_memberssurfaces as unrecoverable.must_refusevectors andexpected_replayvectors; select_credentials must_refuse are an explicit pending list until J5. Verified also against main + wmp#22/build(deps): bump the js-deps group across 1 directory with 3 updates #25 vectors (13 match must_refuse).Deviation: a result listing a member in
redacted_memberswhile also carrying it is refused (go-wmp does not check this).Non-vacuity proven by reverting each rule.
🤖 Generated with Claude Code
https://claude.ai/code/session_011tAXPr6RCod7mUPqXo1pRn