Skip to content

Update schema creation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henriblancke wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update schema creation #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65e4184
[UPD] support direct number type
henriblancke Aug 31, 2020
93b819d
[UPD] multiple types new json schema specs
henriblancke Aug 31, 2020
b3e79cd
[UPD] Add back multipleOf
henriblancke Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions tap_google_sheets/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,22 +149,15 @@ def get_sheet_schema_columns(sheet):
elif column_number_format_type == 'TEXT':
col_properties = {'type': ['null', 'string']}
column_gs_type = 'stringValue'
elif column_number_format_type == 'NUMBER':
col_properties = {'type': ['null', 'number']}
column_gs_type = 'numberType'
else:
# Interesting - order in the anyOf makes a difference.
# Number w/ multipleOf must be listed last, otherwise errors occur.
col_properties = {
'anyOf': [
{
'type': 'null'
},
{
'type': 'number',
'multipleOf': 1e-15
},
{
'type': 'string'
}
]
col_properties = {
'type': ['null', 'number', 'string'],
'multipleOf': 1e-15
}
column_gs_type = 'numberType'
# Catch-all to deal with other types and set to string
Expand Down