Skip to content

Fix PHPdoc return tags and a code warning #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdijen merged 2 commits into from
Jun 13, 2025
Merged

Fix PHPdoc return tags and a code warning #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901374a
Fix PHPdoc return tags and a code warning
rcnsheppardp Jun 13, 2025
0215914
Revert removal and switch to getOptionalValueValidate()
rcnsheppardp Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/MetaLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public function loadSource(array $source): void
/**
* @param \SimpleSAML\Metadata\SAMLParser $entity
* @param array $source
* @bool
* @return bool
*/
private function processCertificates(Metadata\SAMLParser $entity, array $source): bool
{
Expand All @@ -234,7 +234,7 @@ private function processCertificates(Metadata\SAMLParser $entity, array $source)
/**
* @param \SimpleSAML\Metadata\SAMLParser $entity
* @param array $source
* @bool
* @return bool
*/
private function processBlacklist(Metadata\SAMLParser $entity, array $source): bool
{
Expand All @@ -251,7 +251,7 @@ private function processBlacklist(Metadata\SAMLParser $entity, array $source): b
/**
* @param \SimpleSAML\Metadata\SAMLParser $entity
* @param array $source
* @bool
* @return bool
*/
private function processWhitelist(Metadata\SAMLParser $entity, array $source): bool
{
Expand All @@ -268,7 +268,7 @@ private function processWhitelist(Metadata\SAMLParser $entity, array $source): b
/**
* @param \SimpleSAML\Metadata\SAMLParser $entity
* @param array $source
* @bool
* @return bool
*/
private function processAttributeWhitelist(Metadata\SAMLParser $entity, array $source): bool
{
Expand Down
2 changes: 1 addition & 1 deletion src/MetaRefresh.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function runRefresh(string $crontag = null): void
throw new Exception("Invalid outputDir specified.");
}

$outputFormat = $set->getValueValidate('outputFormat', ['flatfile', 'serialize', 'pdo'], 'flatfile');
Comment thread
rcnsheppardp marked this conversation as resolved.
$outputFormat = $set->getOptionalValueValidate('outputFormat', ['flatfile', 'serialize', 'pdo'], 'flatfile');

$oldMetadataSrc = MetaDataStorageSource::getSource([
'type' => $outputFormat,
Expand Down
Loading