Skip to content

Add cmb observation efficiency to quality reports #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmccrackan merged 1 commit into from
Apr 22, 2026
Merged

Add cmb observation efficiency to quality reports #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sotodlib/qa/quality_reports/report_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import sys
from influxdb import InfluxDBClient
from collections import defaultdict
import traceback

from sotodlib.io import hkdb
from sotodlib.io.hkdb import HkConfig
Expand Down Expand Up @@ -176,7 +177,10 @@ def get_apex_data(cfg: ReportDataConfig):
return None

def date_converter(d):
naive_dt = dt.datetime.fromisoformat(d)
if isinstance(d, bytes):
naive_dt = dt.datetime.fromisoformat(d.decode('utf-8'))
else:
naive_dt = dt.datetime.fromisoformat(d)
return naive_dt.replace(tzinfo=dt.timezone.utc)

data = np.genfromtxt(
Expand Down Expand Up @@ -252,7 +256,9 @@ def get_and_merge_apex_pwv(cfg: ReportDataConfig, result=None):
try:
result_apex = get_apex_data(cfg)
except Exception as e:
logger.error(f"get_apex_data failed with {e}")
errmsg = f'{type(e)}: {e}'
tb = ''.join(traceback.format_tb(e.__traceback__))
logger.error(f"get_apex_data failed with {errmsg}\n{tb}")
result_apex = None

if result_apex is not None:
Expand Down
20 changes: 20 additions & 0 deletions sotodlib/site_pipeline/generate_reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,22 @@ def render_report(
else:
unique_obs = [o for o in data.obs_list if o.obs_type == "obs"]

total_time = (dt.datetime.fromisoformat(stop_time_str) - dt.datetime.fromisoformat(start_time_str)).total_seconds() / 3600

if data.pwv is not None:
mask = data.pwv[1] < 3
timediff = np.diff(data.pwv[0][mask])
# prevent gaps from adding time unnecessarily
mask = timediff < 120
good_time = np.sum(timediff[mask]) / 3600
else:
good_time = 0.

cmb_good_pwvtime = np.sum(np.array([o.duration for o in unique_obs if o.obs_subtype == "cmb" and o.pwv < 3])) / 3600
cmb_all_pwvtime = np.sum(np.array([o.duration for o in unique_obs if o.obs_subtype == "cmb" and o.pwv])) / 3600
idle_good_time = good_time - cmb_good_pwvtime
idle_all_time = total_time - cmb_all_pwvtime

jinja_data = {
"data": data,
"report_interval": cfg.report_interval.capitalize(),
Expand All @@ -395,6 +411,10 @@ def render_report(
"Number of Cal Observations": len([o for o in unique_obs if o.obs_subtype == "cal"]),
"Time Spent on CMB Observations (hrs)": np.round(np.sum(np.array([o.duration for o in unique_obs if o.obs_subtype == "cmb"])) / 3600, 1),
"Time Spent on Cal Observations (hrs)": np.round(np.sum(np.array([o.duration for o in unique_obs if o.obs_subtype == "cal"])) / 3600, 1),
"Percentage of Time on CMB Observations (PWV < 3):": np.round(100 * cmb_good_pwvtime / good_time, 2),
"Percentage of Time on CMB Observations:": np.round(100 * cmb_all_pwvtime / total_time, 2),
"Percentage of Time spent not observing CMB (PWV < 3):": np.round(100 * idle_good_time / good_time, 2),
"Percentage of Time spent not observing CMB:": np.round(100 * idle_all_time / total_time, 2),
"Average Duration of CMB Observations (hrs)": np.round(np.nanmean(v) / 3600, 2) if (v := [o.duration for o in unique_obs if o.obs_subtype == "cmb"]) else 0,
"Average Duration of Cal Observations (hrs)": np.round(np.nanmean(v) / 3600, 2) if (v := [o.duration for o in unique_obs if o.obs_subtype == "cal"]) else 0,
"Average Obs PWV (mm)": np.round(np.nanmean([o.pwv for o in unique_obs]), 3),
Expand Down