influxdb: Refactor common drivers to prepare for tagging#466
Open
BrianJKoopman wants to merge 3 commits intomainfrom
Open
influxdb: Refactor common drivers to prepare for tagging#466BrianJKoopman wants to merge 3 commits intomainfrom
BrianJKoopman wants to merge 3 commits intomainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the common InfluxDB drivers in order to make it easier to add InfluxDB tagging for #175.
Motivation and Context
This code is fairly old and kind of a mess. It's maybe still kind of messy, but at least a messy that made it easier to add tagging.
How Has This Been Tested?
The first commit (f56539f) here adds a test for the 'json' protocol, which was missing. And 98a825a adds more tests for single 'timestamp' style messages, which were also missing.
Also, throughout development I had the old code still running with an
assertstatement checking the new code output the same structure. I ran the agent locally using both the 'json' and 'line' protocols.Types of changes
Checklist: