Skip to content

Remove references to __riscv_zvlsseg #1352

Description

@mr-c

Sorry for the archaelogy here. Zvlsseg is an old extension name from pre-1.0 RVV. It was removed from RVV 1.0 and the last several compiler releases never define __riscv_zvlsseg.

Originally posted by @topperc in #1285 (comment)

Activity

  1. mr-c commented on Oct 23, 2025

    @mr-c
    CollaboratorAuthor

    Thank you @topperc for your report; I guess llvm/llvm-project@7a275dc is the relevant commit for LLVM

    Given @Ruhung 's PR that added these references in February, I'm guessing there are some vendor forks of clang out there where this check is still relevant. Any advice from either of you on how to move forward?

  2. mr-c commented on Oct 23, 2025

    @mr-c
    CollaboratorAuthor

    @topperc Isn't our existing check flexible enough?

    simde/simde/simde-arch.h

    Lines 553 to 555 in 9130a9f

    #if defined(__riscv_zvlsseg) || defined(__riscv_v)
    # define SIMDE_ARCH_RISCV_ZVLSSEG 1
    #endif

  3. Ruhung commented on Oct 23, 2025

    @Ruhung
    Contributor

    Remove references to __riscv_zvlsseg.
    #1353

  4. topperc commented on Oct 23, 2025

    @topperc

    @topperc Isn't our existing check flexible enough?

    simde/simde/simde-arch.h

    Lines 553 to 555 in 9130a9f

    #if defined(__riscv_zvlsseg) || defined(__riscv_v)

    define SIMDE_ARCH_RISCV_ZVLSSEG 1

    #endif

    Maybe I took the title of #1285 too literally. It says "only when we have __riscv_zvlsseg flag", but that's not what the code did.

  5. mr-c commented on Oct 23, 2025

    @mr-c
    CollaboratorAuthor

    Shall we leave things as-is to support the older/forked clangs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions