Skip to content

add parameterless constructor to ServerCommit - #102

Merged
hahn-kev merged 1 commit into
mainfrom
parameterless-server-commit
Aug 10, 2026
Merged

add parameterless constructor to ServerCommit#102
hahn-kev merged 1 commit into
mainfrom
parameterless-server-commit

Conversation

@hahn-kev

@hahn-kev hahn-kev commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

required to use in gql in lexbox

Summary by CodeRabbit

  • Bug Fixes
    • Improved commit deserialization and initialization reliability.
    • Ensured commit instances receive valid identifiers when reconstructed from stored or remote data.
    • Resolved required-member initialization warnings during commit creation.

@hahn-kev
hahn-kev enabled auto-merge (squash) August 10, 2026 04:32
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6ce28f1-0b4d-49a7-beef-4d2c8825db16

📥 Commits

Reviewing files that changed from the base of the PR and between 78cb077 and d7c3422.

📒 Files selected for processing (3)
  • src/SIL.Harmony.Core/CommitBase.cs
  • src/SIL.Harmony.Core/ServerCommit.cs
  • src/SIL.Harmony/Commit.cs

📝 Walkthrough

Walkthrough

The commit model constructors now declare required-member initialization. ServerCommit also has a private parameterless constructor that creates a new GUID for GraphQL deserialization.

Changes

Commit constructor initialization

Layer / File(s) Summary
Constructor annotations and GraphQL deserialization
src/SIL.Harmony.Core/CommitBase.cs, src/SIL.Harmony.Core/ServerCommit.cs, src/SIL.Harmony/Commit.cs
The commit constructors use SetsRequiredMembers. ServerCommit adds a private parameterless constructor that initializes the base commit with a new GUID.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a parameterless constructor to ServerCommit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch parameterless-server-commit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hahn-kev
hahn-kev disabled auto-merge August 10, 2026 07:08
@hahn-kev
hahn-kev merged commit e500757 into main Aug 10, 2026
7 checks passed
@hahn-kev
hahn-kev deleted the parameterless-server-commit branch August 10, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant