Separate workspace from project prefixes in the prefix management dialog#1057
Merged
Conversation
J-x-D
reviewed
Jul 13, 2026
J-x-D
approved these changes
Jul 14, 2026
J-x-D
left a comment
J-x-D
left a comment
Contributor
There was a problem hiding this comment.
Catching the exception is still open, but it's probably a matter of taste. lgtm
…62' into feature/prefixSeparation-CMEM-4562
The i18n check (i18next-scanner) failed on the feature branch because 15 PrefixDialog.* keys used via t() had no value in the manual en.json, producing __STRING_NOT_TRANSLATED__ entries. Add English values for all of them (taken from the components' inline defaults). Also add workspacePrefixesDescription, which is only referenced via <Trans> (not scanned, so not flagged) but would otherwise render its raw key. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The sidebar's pre-configured operator list is rebuilt asynchronously when the used-port set changes (reloadToken bump -> loadExternalOperators awaits a Promise before repopulating). After deleting the deprecated node the test asserted on `sidebar-item-normalPort` synchronously, while the sidebar was still mid-reload and the item was transiently absent, so getByTestId threw. Wrap the assertion in waitFor, matching the identical assertions already used elsewhere in this test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.