Add mainnet configs#8344
Merged
mergify[bot] merged 7 commits intosigp:release-v8.0from Nov 3, 2025
Merged
Conversation
eserilev
added
ready-for-review
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
Member
|
I've fixed the tests by resolving a It might be cleaner long term to plumb in a slot clock, but this method suffices for now and is relatively simple. |
michaelsproul
approved these changes
Nov 3, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, and have confirmed correspondence with upstream.
chong-he
approved these changes
Nov 3, 2025
Member
chong-he
left a comment
chong-he
left a comment
There was a problem hiding this comment.
I have checked the values and they match the upstream too.
mergify
Bot
added
ready-for-review
Member
|
Updated the comment to be in sync with: https://github.com/eth-clients/mainnet/pull/11/files#diff-1804ca2400832db3683d071e0734283eadeda1ff359c2c89b88abad1a78b0ef4 Mostly comment changes, and some rearrange of the parameters |
michaelsproul
approved these changes
Nov 3, 2025
michaelsproul
added
ready-for-merge
6 tasks
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Nov 3, 2025
Squashed commit of the following: commit bc301da Author: Tan Chee Keong <[email protected]> Date: Mon Nov 3 12:06:29 2025 +0800 update comment in config commit dc6576e Author: Michael Sproul <[email protected]> Date: Mon Nov 3 14:57:31 2025 +1100 Address review comments commit 841a42f Author: Michael Sproul <[email protected]> Date: Mon Nov 3 12:11:59 2025 +1100 Appease Clippy commit 17d02b8 Author: Michael Sproul <[email protected]> Date: Mon Nov 3 11:37:46 2025 +1100 Fix tests by using correct max_blobs_per_block for epoch commit b941dec Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 13:41:31 2025 -0800 Fmt commit e43209c Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 13:22:48 2025 -0800 Fix test commit 991804e Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 10:36:22 2025 -0800 Add mainnet configs
Merged
mergify Bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
N/A Includes the following unmerged PRs: - #8344 - #8335 - #8339 This PR should be merged after all above PRs are merged. Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#8135
mainnet config PR: eth-clients/mainnet#11