mouse support for QEMU - #603
Open
chombourger wants to merge 3 commits into
Open
Conversation
fmoessbauer
reviewed
Aug 6, 2026
| from mtda.power.controller import PowerController | ||
| from mtda.utils import Size, System | ||
|
|
||
| QMP_SOCKET = "/tmp/qemu-mtda.qmp" |
Member
There was a problem hiding this comment.
Sockets should not be created under /tmp, but run or XDG_RUNTIME_DIR.
Collaborator
Author
There was a problem hiding this comment.
looks like this was a pre-existing issue with this PR adding one more /tmp artefact. commit 1 is now removing all uses of /tmp from power/qemu and console/qemu.
Member
|
Just out of curiosity: How is the performance of this implementation? Is this "good enough" to be exposed via the Web UI for interactive use (similar to PiKVM)? |
Collaborator
Author
our web UI only sends events on a click - would otherwise be too slow but that would be worth looking into (as a separate task) |
Runtime artifacts (monitor and serial fifos, swtpm state dir and socket) were hard-coded under /tmp, colliding across users and sessions and ignoring the system's runtime-file convention. Derive their base directory from XDG_RUNTIME_DIR, falling back to tempfile.gettempdir() when unset. Expose serial_in/serial_out as public attributes so console.qemu, which opens the same fifos, can read them from the power controller instead of duplicating the hard-coded paths. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
HMP over the hand-rolled named-pipe transport had no framing or error reporting: commands and responses were matched by scanning output for the "(qemu) " prompt, so a partial write or an unexpected line desyncs the whole channel with no way to detect it. Connect over QEMU's QMP unix socket instead and speak the native JSON protocol: on()/off()/status() use system_reset/cont/stop/ query-status, and usb_add()/usb_rm() use blockdev-add/device_add/ device_del/blockdev-del, tracking attached ids locally instead of scraping "info usb" text. keyboard.qemu and video.qemu move to the native send-key and screendump QMP commands for the same reason. The free-form command() CLI passthrough (mtda-cli command ...) still needs to accept arbitrary HMP strings (e.g. hostfwd_add), so it now bridges through QMP's human-monitor-command instead of the raw pipe. self.lock becomes an RLock: usb_add()/usb_rm() hold it across several qmp() calls, and qmp() itself locks. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
No mouse variant existed for QEMU (only the physical HID gadget), so mtda-cli mouse move was a silent no-op against a qemu-backed device. Drive the target pointer over QMP's input-send-event, and add -device usb-tablet so mouse_move's coordinates are read as absolute positions instead of relative deltas. input-send-event routes "abs" events to the usb-tablet automatically: it's the only pointing device that declares absolute-axis support, so position events reach it unambiguously with no selection step. Button events are shared between the tablet and the default machine's relative PS/2 mouse, and QEMU applies them to whichever pointer it last made active; QMP has no command for that, so fall fall back to the human-monitor-command bridge to select the tablet, but only when query-mice (native QMP) reports it isn't already active. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
chombourger
force-pushed
the
ch/feat/qemu-mouse
branch
from
August 6, 2026 15:06
4de164c to
fd6c963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.