Qt 4/5 specific screen grab routines#105
Open
j0yu wants to merge 2 commits into
Open
Conversation
j0yu
pushed a commit
to wwfxuk/tk-framework-qtwidgets
that referenced
this pull request
Apr 28, 2020
…x' and 'qt5-screen-grab' See in order on https://github.com: - shotgunsoftware/pull/92 to match wwfxuk/tk-framework-qtwidgets/tree/v2.8.3%2Bwwfx.1.0.0 - /pull/2 to match wwfxuk/tk-framework-qtwidgets/tree/v2.8.3%2Bwwfx.1.1.0 - shotgunsoftware/pull/105 to match wwfxuk/tk-framework-qtwidgets/tree/v2.8.5%2Bwwfx.1.0.2
Contributor
|
Hi @j0yu , thank you for this. I'm going to track this JIRA so we can have a developer take a look at the fix. |
added 2 commits
March 10, 2021 16:38
* Initial fix * Py3 friendly long * Fixed missing :, extra comment space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt4's QPixmap.grabWindow has been removed in Qt5 and their Qt5 Screenshot Example has changed to use QScreen.grabWindow.
Discovered with Katana 3.1 (PyQy5), this PR fixes the following error:
AttributeError: type object 'QPixmap' has no attribute 'grabWindow'
Also includes similar fix for Maya 2019 to #95
See also:
diffyourself between Qt5 Screenshot Example's screenshot.cpp and Qt4 Screenshot Example's screenshot.cpp