fix: Update Twitter(X) detection logic in data.json#2909
Open
rigen1048 wants to merge 1 commit intosherlock-project:masterfrom
Open
fix: Update Twitter(X) detection logic in data.json#2909rigen1048 wants to merge 1 commit intosherlock-project:masterfrom
rigen1048 wants to merge 1 commit intosherlock-project:masterfrom
Conversation
Contributor
Automatic validation of changes
|
rigen1048
changed the title
Author
|
Hey @ppfeister @sdushantha, I was wondering if there’s anything I can do to help move this PR forward.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X no longer includes "This account doesn’t exist" reliably in the initial HTML response for non-existent profiles due to heavy client-side rendering.
The server now returns the same shell (with loading state + X logo) for both claimed and non-existent usernames, and the real success/failure decision lives in the
__INITIAL_STATE__JSON."ApiError"and"\"code\":50"that only appear when the username is not found.urlProbeupdated to officialhttps://x.com/{}(Nitter instance is dead).Tested manually:
jdhjasds(non-existent) → correctly reports Availableblue(claimed) → correctly reports ClaimedThis should resolve the long-standing broken Twitter probe that multiple automated attempts couldn't fix.