fix: handle UnicodeDecodeError on usernames with special characters#2899
Open
Bahtya wants to merge 1 commit intosherlock-project:masterfrom
Open
fix: handle UnicodeDecodeError on usernames with special characters#2899Bahtya wants to merge 1 commit intosherlock-project:masterfrom
Bahtya wants to merge 1 commit intosherlock-project:masterfrom
Conversation
…ixes sherlock-project#2730) Added a UnicodeError exception handler in get_response() to catch UnicodeDecodeError and UnicodeEncodeError that can occur when the requests library handles redirects from servers with improperly encoded URLs. This prevents the program from crashing when scanning usernames with special characters (e.g., 'Émile'). The fix treats these errors similarly to other connection errors, allowing the scan to continue gracefully. Bahtya
Author
|
@ppfeister Friendly ping 👋 This is a resubmission of #2893 (closed) from a proper feature branch. The fix handles UnicodeDecodeError when processing usernames with special characters (fixes #2730). Would appreciate a review. |
Author
|
Hi @ppfeister, friendly ping. This fix handles UnicodeDecodeError when processing usernames with special characters. Would appreciate a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2730
When processing usernames containing special characters (non-ASCII), Sherlock crashes with a
UnicodeDecodeError. This PR wraps the username handling in proper encoding error handling.Changes
Testing
Re-opens #2893 from a proper feature branch instead of fork master.