Skip to content

fix: correct None check for query_time in xlsx response_time_s output#2892

Open
mango766 wants to merge 1 commit intosherlock-project:masterfrom
mango766:fix/xlsx-response-time-none-check
Open

fix: correct None check for query_time in xlsx response_time_s output#2892
mango766 wants to merge 1 commit intosherlock-project:masterfrom
mango766:fix/xlsx-response-time-none-check

Conversation

@mango766
Copy link
Copy Markdown

@mango766 mango766 commented Apr 9, 2026

Fixes #2891

The --xlsx output block initializes response_time_s as a list and then checks if response_time_s is None before appending — but a list is never None, so the fallback empty string path is dead code. Sites that don't return a response time (timeouts, errors) end up with raw None values in the Excel column instead of a blank cell.

The fix mirrors what the --csv block already does correctly: check results[site]["status"].query_time is None rather than the accumulator list.

One-line change, no behaviour change for sites that do return a response time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: xlsx output always appends None for response_time_s when query_time is missing

1 participant