fix: correct None check for query_time in xlsx response_time_s output#2892
Open
mango766 wants to merge 1 commit intosherlock-project:masterfrom
Open
fix: correct None check for query_time in xlsx response_time_s output#2892mango766 wants to merge 1 commit intosherlock-project:masterfrom
mango766 wants to merge 1 commit intosherlock-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2891
The
--xlsxoutput block initializesresponse_time_sas a list and then checksif response_time_s is Nonebefore appending — but a list is neverNone, so the fallback empty string path is dead code. Sites that don't return a response time (timeouts, errors) end up with rawNonevalues in the Excel column instead of a blank cell.The fix mirrors what the
--csvblock already does correctly: checkresults[site]["status"].query_time is Nonerather than the accumulator list.One-line change, no behaviour change for sites that do return a response time.