Fix code quality issues: silent exceptions, type hints, dead code#2885
Open
Rsan0948 wants to merge 1 commit intosherlock-project:masterfrom
Open
Fix code quality issues: silent exceptions, type hints, dead code#2885Rsan0948 wants to merge 1 commit intosherlock-project:masterfrom
Rsan0948 wants to merge 1 commit intosherlock-project:masterfrom
Conversation
- Replace 5 bare except:pass blocks with logging.debug() - Add type annotations to QueryNotify, QueryResult, SiteInformation - Fix ignored username_unclaimed parameter in SiteInformation - Prefix unused signal_received parameter with _ (convention) - Add return type hints to helper functions (get_response, multiple_usernames, etc.)
Rsan0948
force-pushed
the
fix-sherlock-quality
branch
from
f7a2a0c to
b5a2417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 5 bare except:pass blocks with logging.debug()
Add type annotations to QueryNotify, QueryResult, SiteInformation
Fix ignored username_unclaimed parameter in SiteInformation
Prefix unused signal_received parameter with _ (convention)
Add return type hints to helper functions (get_response, multiple_usernames, etc.)
All done using HelicOps