Skip to content

fix(site): detect missing Shelf profiles by message#2878

Open
kuishou68 wants to merge 1 commit intosherlock-project:masterfrom
kuishou68:cocoon/fix-shelf-false-negative
Open

fix(site): detect missing Shelf profiles by message#2878
kuishou68 wants to merge 1 commit intosherlock-project:masterfrom
kuishou68:cocoon/fix-shelf-false-negative

Conversation

@kuishou68
Copy link
Copy Markdown

Summary

  • update Shelf detection to use the page's User Not Found marker instead of HTTP status
  • fix the current false-negative behavior for existing Shelf profiles
  • keep the change isolated to the single site manifest entry

Notes

  • I validated the site behavior from this environment: both claimed and unclaimed Shelf usernames return HTTP 200, and missing profiles include User Not Found in the response body.

Closes #2806

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

Automatic validation of changes

Target F+ Check F- Check
Shelf ✔️   Pass ✔️   Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False negative for: Shelf

1 participant