Skip to content

fix(cli): normalize invalid timeout parse errors #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuishou68 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): normalize invalid timeout parse errors #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sherlock_project/sherlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,12 @@ def timeout_check(value):
NOTE: Will raise an exception if the timeout in invalid.
"""

float_value = float(value)
try:
float_value = float(value)
except (TypeError, ValueError) as exc:
raise ArgumentTypeError(
f"Invalid timeout value: {value}. Timeout must be a positive number."
) from exc

if float_value <= 0:
raise ArgumentTypeError(
Expand Down
9 changes: 9 additions & 0 deletions tests/test_ux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,12 @@ def test_wildcard_username_expansion():
def test_no_usernames_provided(cliargs):
with pytest.raises(InteractivesSubprocessError, match=r"error: the following arguments are required: USERNAMES"):
Interactives.run_cli(cliargs)

@pytest.mark.parametrize('cliargs', [
'--timeout abc testuser',
'--timeout not-a-number testuser',
])
def test_invalid_timeout_reports_argparse_error(cliargs):
with pytest.raises(InteractivesSubprocessError, match=r"argument --timeout: Invalid timeout value"):
Interactives.run_cli(cliargs)