ensure pip is actually upgraded during Docker build#2871
Open
ankit1w wants to merge 1 commit intosherlock-project:masterfrom
Open
ensure pip is actually upgraded during Docker build#2871ankit1w wants to merge 1 commit intosherlock-project:masterfrom
ankit1w wants to merge 1 commit intosherlock-project:masterfrom
Conversation
Previously, pip was upgraded in an isolated AS build stage that was never copied into the final image, meaning the upgrade was completely discarded. This commit removes the unused multi-stage block and moves the pip upgrade into the final stage. This ensures the container actually uses the latest version of pip when installing the project dependencies, while also cleaning up dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, pip was upgraded in an isolated AS build stage that was never copied into the final image, meaning the upgrade was completely discarded. This commit removes the unused multi-stage block and moves the pip upgrade into the final stage. This ensures the container actually uses the latest version of pip when installing the project dependencies, while also cleaning up dead code.