Python3 support, autopep8 formatting, fix for os.startfile()#10
Closed
skypeachblue wants to merge 4 commits into
Closed
Python3 support, autopep8 formatting, fix for os.startfile()#10skypeachblue wants to merge 4 commits into
skypeachblue wants to merge 4 commits into
Conversation
Closed
Owner
|
Thanks for your contribution! Can you send pr again on branch "PCRT-python3"? I just created it and I think it's a better choice for users :-) |
Author
|
Ok I just did :) #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted to Python3
Formatted the code with autopep8
os.startfile() is a windows-only function, I created the startfile() function which checks the platform and calls the correct function to make this work on Linux
Tested with the example files on Manjaro Linux Python 3.10