Repository navigation
refactor(i18n): show code search and worktree scripts through Fluent - #962
Merged
Merged
Conversation
Part of Phase 2 of docs/i18n.md. Migrates the connection-side modules: state, daemon, endpoint, sessions, settings_panel, and the taskbar badge's spoken count, and marks the modules whose literals never reach a window (setup_relay, host_build, herdr_settings, app_icon, sound, terminal_notes) as migrated with their scripts, log text, and agent prompts tagged data. Errors these modules turned into a String with to_string() now use localize(). Endpoint::status stays English for herdr-gpui commands, and the device picker reads the new status_label.
…h Fluent Part of Phase 2 of docs/i18n.md. Migrates system_load, network_quality, listening_ports, code_server, and remote_browser: the status bar's labels, tooltips, and spoken text, the port tunnels' hints and notices, the VS Code server's license terms, and remote page requests' notices. Plurals (cores, cards, probes) are selectors, sizes and uptimes are messages, and errors use localize(); a failed reading keeps its causes through the new i18n::errors::with_causes. Host scripts, parse keys, and log Display text are tagged data.
Part of Phase 2 of docs/i18n.md. Migrates code_search (titles, tabs, placeholders, counts, hints, symbol kinds, and badges), worktree_scripts (the trust page and its errors), and repo_items (the remote checkout's failure). Code search's changed-file line reads ago, as #940 meant to do: that PR was merged into its stacked base and never reached main. Symbol kinds come from the index's typed Kind, not its English label. Errors use localize(); Git step names, scripts, and the task context an agent reads are tagged data.
Collaborator
Author
|
|
 [Low impact] The PR appears safe to merge; no actionable issues were found. SummaryMoves code search, worktree script prompts, and remote checkout failure text into Fluent.
Reviews (5) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This was referenced Nov 1, 2026
…guage Windows' taskbar speaks the badge's count, but the badge was published again only when the count changed, so a language switch left its description in the old language. It now records the locale it was described in and publishes again when the shown locale changes. The local socket warning went through local_feedback_multiline, whose cleanup for daemon text strips direction marks, so en-XB and right-to-left languages lost them. The app's own Fluent title and body are now set with with_message after it; the chmod line only carries a path body() already refused when unsafe.
Collaborator
Author
|
@greptileai review |
Collaborator
Author
|
@greptileai review |
# Conflicts: # docs/i18n.md
Every open i18n pull request edited that list, so each merge made the others conflict. One pull request updates it after they all merge.
# Conflicts: # crates/herdr-gpui/src/worktree_scripts.rs # docs/i18n.md
Collaborator
Author
|
@greptileai review |
Collaborator
Author
|
@greptileai review |
✅ Deploy Preview for herdr-ui canceled.
|
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #957 (base
i18n/left-status), which is stacked on #953. Merge those first; this PR's base then becomesmain.Summary
Part of Phase 2 of
docs/i18n.md, following #880, #926/#928, #925/#940 (ago), and #941/#943. This PR covers code search, worktree scripts, and repository items.Migrated (
// i18n: migrated)code_search(code-search.ftl):Kind, notKind::label's English, whichherdr-gpui searchkeeps.set_placeholder_with, so they follow a language change.ago. This ports feat(i18n): show Security, code search, and orchestrator times through ago #940's code search part. feat(i18n): show Security, code search, and orchestrator times through ago #940 was merged into its stacked base (fix/i18n-errors-after-905), and that base never reachedmain, somainstill had the hand-built "5m ago". Security's and the orchestrator's parts of feat(i18n): show Security, code search, and orchestrator times through ago #940 belong to other scopes and are still missing; this PR leavesdocs/i18n.mdunchanged.worktree_scripts(worktree-scripts.ftl): the trust page, its buttons, and the missing-script and did-not-start errors. Each uses a selector on the script's kind.repo_items(repo-items.ftl): the remote checkout's SSH failure. Git step names (which the Git error mapping matches), GraphQL, scripts, and the task context an agent reads are tagged data.Errors: code search and worktree script errors use
localize()instead ofto_string().English changes: a changed file's line reads "5 min ago" and "yesterday" instead of "5m ago" and "1d ago", as #940 intended.
Screenshots
Native macOS captures from a debug build of the stack's tip, running against an isolated sandbox
herdr server. The surfaces were opened withherdr-gpui run/open/fan-outand the language set in the sandbox config; no synthetic input was used. The checkout has one changed and one new file.QA
just formatjust cion94337b2c5(macOS arm64): passed, 16,368 tests, 0 failedcode_search/tests/en_xa.rs)code_search/tests/changed.rs, from feat(i18n): show Security, code search, and orchestrator times through ago #940).herdr/worktree.tomlasks to run its setup script; the trust page reads translatedjust lint-linuxandjust lint-windowswere not run: no platformcfggate changed.