Repository navigation
Conversation
#905 (iOS app, one pairing for every machine) and #926 (localized errors) merged independently. #905 moved herdr-automate's binary, checksum, and platform failures into host_build::Error and added herdr_client::Error::TerminalAttach, remote control's app::Error::Enroll, and the root Error::Nearby, none of which had a Localize mapping, so main no longer compiled. Each new enum gets its own mapping and .ftl file, as #926 set out: host_build (error-host-build.ftl, which takes over the three automation messages), terminal_attach (error-client-terminal-attach.ftl), nearby (error-nearby.ftl), and enroll (in error-remote-control.ftl). Per-variant tests cover each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFavh5CsF9aiVsJURUwioh
✅ Deploy Preview for herdr-ui canceled.
|
Collaborator
Author
|
|
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRestores exhaustive error mappings after the earlier error-enum changes.
No actionable issues were found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "style(i18n): keep the client error mappi..." · Reviewed by Greptile |
This was referenced Oct 31, 2026
… messages (#938) The move's progress line, the review's "what runs there" line, and the warnings a finished move flashes were English: the progress came from `Step::label`, the review from herdr-remote's `describe`, and the warnings were strings herdr-remote formatted. Failures went through `to_string()`. herdr-remote now reports warnings as a typed `teleport::Warning`, with an English `Display` kept for logs, and the session-only review exposes the resume it runs instead of describing it. The app renders steps, pane lines, and warnings through `teleport/text.rs`, which the Teleport dialog already used, so both moves share one set of messages. Errors in the move and in the Teleport dialog go through `localize()`, and the dialog's poll result keeps the typed error instead of a `String`. `menu/mute.rs` and `menu/page.rs` show no text and are marked migrated, so every file in `menu/` is now covered. An en-XA leak test covers the move's review, progress, failure, and every warning's flash.
…h ago (#940) Part of Phase 2 of docs/i18n.md. Security, code search, and the orchestrator each built their own "5 min ago" in Rust; they now read the shared ago module, so every relative time in the app comes from ago.ftl. - ago::short ("now", "12m", "5h", "3d", "2w") is the compact form for list columns, where the orchestrator's issue and pull request rows used a hand-built one. - Security drops its security-ago-* messages. Its failed reads show through localize(), from a new error-security.ftl mapping, instead of to_string(). - Code search's "New 5 min ago" line under a changed file is one message per case, not a word joined to a time. - The orchestrator's facts line under an item's title ("opened 2 h ago", "+3 −1 in 2 files") is messages, with a selector for the file count. English changes: a time between one and two days ago reads "yesterday", the orchestrator's comments say "just now" and "2 h ago" rather than "now" and "2h ago", and a one-file pull request says "1 file".
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainat71652d3e6does not compile. #905 (iOS app, one pairing for every machine) and #926 (localized errors) merged independently. #905 changed or added several error enums, and #926's mappings don't match them:Binary,Checksum, andPlatformvariants moved intohost_build::Error.automations::Errornow wraps that error asBuild.herdr_client::Error::TerminalAttach(terminal_attach::Error)herdr_remote_control::app::Error::Enroll(enroll::Error)Error::Nearby(remote::nearby::Error)Localizematches every variant on purpose, so none of these compiled. Each new enum now gets its own mapping and.ftlfile, following #926:host_build::Errori18n/errors/host_build.rserror-host-build.ftl(takes over the three automation messages, now naming the program)terminal_attach::Errori18n/errors/client/terminal_attach.rserror-client-terminal-attach.ftlremote::nearby::Errori18n/errors/nearby.rserror-nearby.ftlenroll::Errori18n/errors/remote_control.rserror-remote-control.ftlEnglish text is the same as each variant's
Display.QA
Display, and the en-XA text is marked. The tests for root, client, automations, and remote control cover the new wrapping variants.just ciona54057bc4(macOS arm64): passed, 16,282 tests, 0 failed; check-i18n: 3609 messages in 154 files valid and usedjust lint-linux/just lint-windows: not run. Nocfggates were touched.No screenshots: there are no visible changes. Errors read the same in English.
The other i18n branches in progress (menus, pages, chat/browser, window) build on this branch until it lands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BFavh5CsF9aiVsJURUwioh