feat(domain): add remotion video skill to default injection#567
Open
feat(domain): add remotion video skill to default injection#567
Conversation
Contributor
Contributor
arielshad
changed the title
Contributor
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Update settings-defaults.factory tests for RED phase: skill count assertions changed from 8 to 20, names array extended with 12 new entries (1 remotion + 11 shep-ai/promo GTM skills), and WorkflowConfig snapshot updated with corresponding SkillSource objects. Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Append remotion-best-practices (remotion-dev/skills) and 11 shep-ai/promo GTM skills to the default skill injection array, bringing total from 8 to 20. All entries use SkillSourceType.Remote with explicit remoteSkillName matching the existing pattern. Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
… results Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
… results Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
The shep-ai/promo repo is private, so npx skills add would fail for users without GitHub access. Remove all 11 promo skill entries from the default skill injection config. Keep only the public remotion-dev/skills entry (remotion-best-practices). Default skill count drops from 20 to 9. Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
Co-Authored-By: Shep Bot <shep-agent@users.noreply.github.com>
arielshad
force-pushed
the
feat/gtm-video-skills
branch
from
248db24 to
d648618
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remotion-dev/skillsto the default skill injection configurationWhy only Remotion?
The original plan included 11 GTM skills from
shep-ai/promo, but that repo is private —npx skills addwould fail for users without GitHub access. Those skills were removed to keep defaults working out of the box.Changes
packages/core/src/domain/factories/settings-defaults.factory.tsremotion-best-practicesSkillSource entrytests/unit/domain/factories/settings-defaults.factory.test.tsTest plan
pnpm typecheck— passespnpm lint— passespnpm test:unit— 520 files, 6836 tests all passingpnpm build— compiles successfully🐑 Built with Shep.bot