feat(web): add evidence image lightbox with gallery grid and fullscreen navigation#470
Open
feat(web): add evidence image lightbox with gallery grid and fullscreen navigation#470
Conversation
…mage lightbox Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rd support New standalone EvidenceLightbox component in common/evidence-lightbox/ that displays evidence images in a fullscreen Radix Dialog with prev/next navigation, keyboard arrow support, wrap-around, image counter, description, and download button. Includes 20 unit tests covering all functionality. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split EvidenceList into image gallery grid and non-image expandable list. Image evidence renders as a 3-column CSS grid of clickable square thumbnails that open the EvidenceLightbox component. Non-image evidence continues to render as expandable EvidenceItem entries below the gallery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Stories cover: default gallery grid, lightbox open state, single image, many images, mixed evidence types, and controlled lightbox. Uses a GalleryWithLightbox wrapper to demonstrate thumbnail grid + lightbox integration matching EvidenceList behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Increase timeouts for feature-create-drawer repository selector tests that use userEvent.type() with multi-character strings. Also fix port.service test to use toBeGreaterThanOrEqual instead of exact port match, since port availability depends on host environment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
arielshad
force-pushed
the
feat/evidence-image-lightbox
branch
from
daa4043 to
a77b221
Compare
Contributor
Remove comment line in port.service.test.ts that conflicted with main branch changes. Update spec yaml timestamps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Resolve merge conflict in port.service.test.ts by keeping the explanatory comment from main about port occupation assertions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Clear SHEP_SKIP_RECOVERY env var in recoverAll tests so recovery logic is actually exercised when running inside a shep subprocess - Update evidence rendering test to use getByAltText since image evidence descriptions are now alt text on gallery thumbnails Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-black/90) with the image at natural aspect ratio (object-contain, up to90vh), prev/next navigation buttons, keyboard arrow key support, wrap-around navigation, image counter, truncated description, and download buttonWhat Changed
src/presentation/web/components/common/evidence-lightbox/src/presentation/web/components/common/evidence-lightbox/evidence-lightbox.stories.tsxsrc/presentation/web/components/common/merge-review/merge-review.tsxsrc/presentation/web/components/common/merge-review/merge-review.stories.tsxtests/unit/presentation/web/components/common/evidence-lightbox/Evidence
Gallery Grid
Lightbox Open
Lightbox Navigation
Storybook Stories
Tests
Test plan
🤖 Generated with Claude Code