fix: pager EOF lockup bug#380
Merged
Merged
Conversation
ethanpailes
force-pushed
the
fix-pager-eof-lockup
branch
2 times, most recently
from
788816c to
660bdcf
Compare
51609f8 introduced a regression where shpool would lock up when displaying the message of the day in a pager process like less because it would return an error instead of just terminating the pager display process by returning the current tty size as it ought to have. This is arguably the first slop bug shpool has had since gemini helped me find the issue that 51609f8 was trying to address, though I wrote the fix that caused the regression. The original CPU pinning EOF bug was real though, it was just my fix that was bad. I yanked versions 0.10.0 an 0.10.1 over this issue, which might be too extreme now that I have discovered the problem (I think I might be the only person who uses this feature), but at the time I didn't have the cycles to investigate. There are some unrelated test tweaks to deflake some tests.
ethanpailes
force-pushed
the
fix-pager-eof-lockup
branch
from
660bdcf to
73db3e9
Compare
maxhbooth
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
n/a
AI Policy Ack
Ack
This PR was:
Meat coded the investigation and fix, vibed a regression test.
Description
51609f8 introduced a regression where shpool would lock up when displaying the message of the day in a pager process like less because it would return an error instead of just terminating the pager display process by returning the current tty size as it ought to have.
This is arguably the first slop bug shpool has had since gemini helped me find the issue that 51609f8 was trying to address, though I wrote the fix that caused the regression. The original CPU pinning EOF bug was real though, it was just my fix that was bad.
I yanked versions 0.10.0 an 0.10.1 over this issue, which might be too extreme now that I have discovered the problem (I think I might be the only person who uses this feature), but at the time I didn't have the cycles to investigate.