Switch CI to dtolnay/rust-toolchain@nightly, run cargo directly, and fix rc5 test typo#106
Draft
shekohex wants to merge 6 commits into
Draft
Switch CI to dtolnay/rust-toolchain@nightly, run cargo directly, and fix rc5 test typo#106shekohex wants to merge 6 commits into
dtolnay/rust-toolchain@nightly, run cargo directly, and fix rc5 test typo#106shekohex wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dtolnay/rust-toolchain@nightlyand invokingcargodirectly instead of relying on theactions-rshelper actions.Description
/.github/workflows/ci.ymlto usedtolnay/rust-toolchain@nightlyand replaceactions-rs/cargo@v1steps with directrun: cargo buildandrun: cargo testinvocations./.github/workflows/lints.ymlto usedtolnay/rust-toolchain@nightly, enablerustfmtandclippycomponents, and runcargo fmt --all -- --checkandcargo clippy -- -D warningsdirectly.crates/crypto/src/rc5.rswhereorigionalwas renamed tooriginalin an assertion inside theencrypt_decrypttest.Testing
cargo fmt --all -- --checkandcargo clippy -- -D warningsand they succeeded.cargo buildandcargo testand all unit tests (including therc5tests) passed.Codex Task