Skip to content

Update Spirv-Tools Mar-27 2026#10670

Merged
jkwak-work merged 1 commit into
shader-slang:masterfrom
jkwak-work:update/spirv-tools-mar-2026
Mar 30, 2026
Merged

Update Spirv-Tools Mar-27 2026#10670
jkwak-work merged 1 commit into
shader-slang:masterfrom
jkwak-work:update/spirv-tools-mar-2026

Conversation

@jkwak-work
Copy link
Copy Markdown
Collaborator

No description provided.

@jkwak-work jkwak-work self-assigned this Mar 27, 2026
@jkwak-work jkwak-work requested a review from a team as a code owner March 27, 2026 18:57
@jkwak-work jkwak-work requested review from bmillsNV and removed request for a team March 27, 2026 18:57
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • external/spirv-headers is excluded by !external/**
  • external/spirv-tools is excluded by !external/**
  • external/spirv-tools-generated/build-version.inc is excluded by !external/**
  • external/spirv-tools-generated/core_tables_body.inc is excluded by !external/**
  • external/spirv-tools-generated/core_tables_header.inc is excluded by !external/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1fb4390d-aeba-44d9-b3fa-888ec15e021a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jkwak-work
Copy link
Copy Markdown
Collaborator Author

This is to include the fix for SpirvOpt crashing issue:

Copy link
Copy Markdown
Contributor

@aidanfnv aidanfnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Acknowledging that the commit being used is for an unmerged SPIRV-Tools PR, but that PR looks good to me as well (although it will be up to the SPIRV-Tools team to actually judge that).

@jkwak-work jkwak-work added this pull request to the merge queue Mar 30, 2026
Merged via the queue into shader-slang:master with commit 80b74a9 Mar 30, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: non-breaking PRs without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants