Skip to content

test(comments): cover the list_controller.notifyProgrammaticScroll seam #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sh1nj1 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

test(comments): cover the list_controller.notifyProgrammaticScroll seam #1408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...llavre/app/javascript/controllers/comments/__tests__/list_controller_prev_message.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,21 @@ describe('list_controller previous-message navigation', () => {
expect(h.controller.prevMsgNavigator.anchorId).toBeNull()
})

test('notifyProgrammaticScroll seam drops the anchor for sibling controllers', () => {
// The review-quote chip in form_controller scrolls the list on its own and
// drops the anchor through this public seam, without reaching into the
// navigator's internals. Exercise the real seam, not a mock of it.
const h = buildController()
h.scrollTo(4 * ITEM_HEIGHT)

h.controller.scrollToPreviousMessage() // anchor = c3
expect(h.controller.prevMsgNavigator.anchorId).toBe('c3')

h.controller.notifyProgrammaticScroll()

expect(h.controller.prevMsgNavigator.anchorId).toBeNull()
})

test('disconnect unhooks the user-input listeners', () => {
const h = buildController()
h.scrollTo(4 * ITEM_HEIGHT)
Expand Down
Loading