Skip to content

fix(android): keep the API bearer token out of device backups #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sh1nj1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): keep the API bearer token out of device backups #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/android-app/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@

<application
android:name=".VoiceApp"
android:allowBackup="true"
android:allowBackup="false"
android:dataExtractionRules="@xml/data_extraction_rules"
android:icon="@drawable/ic_launcher"
android:label="@string/app_name"
android:networkSecurityConfig="@xml/network_security_config"
Expand Down
22 changes: 22 additions & 0 deletions tools/android-app/app/src/main/res/xml/data_extraction_rules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
The companion stores a Doorkeeper bearer token (full mobile-API access to the
user's Collavre account) in the `collavre_voice` Preferences DataStore. That
file is app-private but plaintext, so it must never leave the device via a
backup channel. allowBackup="false" already blocks Auto Backup and adb backup;
on Android 12+ dataExtractionRules governs cloud-backup and device-transfer
SEPARATELY, so we exclude the file domain (where the datastore lives) from
BOTH — otherwise a device-to-device migration would copy the token in cleartext.
-->
<data-extraction-rules>
<cloud-backup>
<exclude domain="file" />
<exclude domain="sharedpref" />
<exclude domain="database" />
</cloud-backup>
<device-transfer>
<exclude domain="file" />
<exclude domain="sharedpref" />
<exclude domain="database" />
</device-transfer>
</data-extraction-rules>
Loading