Skip to content

[CI] Fix mxfp8 TrtllmGenMoe test#23125

Merged
b8zhong merged 2 commits into
sgl-project:mainfrom
zianglih:mxfp8-ci
Apr 24, 2026
Merged

[CI] Fix mxfp8 TrtllmGenMoe test#23125
b8zhong merged 2 commits into
sgl-project:mainfrom
zianglih:mxfp8-ci

Conversation

@zianglih

@zianglih zianglih commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Motivation

@HumansAnd

mxfp8 test regressed after #21667 (reference: #22136).

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@zianglih

Copy link
Copy Markdown
Contributor Author

Hi @Fridge003 @b8zhong could you help review this tiny ci fix? Thank you!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test configuration for the Flashinfer TRTLLM MoE backend by switching to a specific MXFP8 quantized model and changing the --fp8-gemm-backend to flashinfer_cutlass. Feedback suggests moving the model checkpoint from a personal repository to an official organization account to ensure long-term availability and security for the CI suite. Additionally, there is a concern that switching the GEMM backend to cutlass in a test specifically intended for flashinfer_trtllm reduces test coverage for the target integration, suggesting that the underlying numerical issues should be fixed rather than bypassed.

Comment thread test/registered/backends/test_flashinfer_trtllm_gen_moe_backend.py
Comment thread test/registered/backends/test_flashinfer_trtllm_gen_moe_backend.py
@zianglih zianglih changed the title [ci] Fix mxfp8 TrtllmGenMoe test [CI] Fix mxfp8 TrtllmGenMoe test Apr 22, 2026

@b8zhong b8zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag-and-rerun-ci

@b8zhong
b8zhong enabled auto-merge (squash) April 23, 2026 13:33
@b8zhong b8zhong added the run-ci label Apr 23, 2026
@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-stage stage-c-test-4-gpu-b200

@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

4 similar comments
@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@zianglih

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@b8zhong
b8zhong merged commit 1758856 into sgl-project:main Apr 24, 2026
453 of 508 checks passed
@zianglih
zianglih deleted the mxfp8-ci branch April 24, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants