fix: fixes skipped Scenario Outlines with tagged examples in report#3735
Open
gematik-florian wants to merge 1 commit into
Open
fix: fixes skipped Scenario Outlines with tagged examples in report#3735gematik-florian wants to merge 1 commit into
gematik-florian wants to merge 1 commit into
Conversation
…n Report Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Scenario Outline examples reported as skipped when separated by tags
Summary of this PR
Fixes a reporting bug mentioned in #3691 in
BaseStepListener.testAndTopLevelStepsShouldBeIgnored()where passed example rows of a CucumberScenario Outlinewith multiple tag-separatedExamplesblocks were incorrectly rendered as skipped in the Serenity report.Intended effect
Examplesblock was filtered/ignored via tags, all previously passed rows of the same outline were retroactively marked asIGNORED. Failed rows were correct.IGNORED. Passed rows staySUCCESS, failed rows stayFAILURE, and the overall outline result is no longer downgraded when prior rows already produced a result.How should this be manually tested?
serenity-demos), create aScenario Outlinewith twoExamplesblocks, one tagged@skip.-Dcucumber.filter.tags="not @skip".@skiprow renders as ignored,Before the fix, step 3 would show all rows as skipped.
Side effects
updateTopLevelStepResultsTo(IGNORED)is no longer called — theIGNOREDmarker is now scoped to the current row viaupdateCurrentRowResult(IGNORED).TestOutcomeresult is set toIGNOREDonly when it is stillnull/UNDEFINED, preserving results from earlier rows.private).Relevant tickets
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com"