Repository navigation
fix: pin our dependencies for secure pos CCA leak keys - #324
Merged
Merged
Conversation
joaozinhom
marked this pull request as draft
October 21, 2026 22:21
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 95.87% 96.10% +0.22%
==========================================
Files 28 29 +1
Lines 1796 1927 +131
Branches 205 219 +14
==========================================
+ Hits 1722 1852 +130
- Misses 57 59 +2
+ Partials 17 16 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joaozinhom
force-pushed
the
pin_version
branch
from
October 21, 2026 22:27
05ed4cc to
8f336c5
Compare
joaozinhom
force-pushed
the
pin_version
branch
from
October 21, 2026 22:44
8f336c5 to
cc29b12
Compare
joaozinhom
marked this pull request as ready for review
October 22, 2026 17:43
qlrd
reviewed
Oct 24, 2026
qlrd
left a comment
qlrd
left a comment
Member
There was a problem hiding this comment.
Some nits (not requesting changes so we can discuss better this steop). I think a change on CHANGELOG.md would be neat
| "pyserial>=3.5", | ||
| "easy-i18n>=1.2.0", | ||
| "pysudoer @ git+https://github.com/qlrd/pysudoer.git@v0.0.3", | ||
| "pysudoer @ git+https://github.com/qlrd/pysudoer.git@4738b19743dc6aeb328ededc08960a967cf0bd91", |
Member
There was a problem hiding this comment.
why is better to pin to hash than version?
joaozinhom
force-pushed
the
pin_version
branch
from
October 26, 2026 14:35
cc29b12 to
ae8d65c
Compare
qlrd
approved these changes
Oct 27, 2026
qlrd
left a comment
qlrd
left a comment
Member
There was a problem hiding this comment.
IMO ACK 1f29f7d0
(if someone finds more things, i will re-review).
Built the firmware locally with Docker from and it succeeded, so the pinned and hash-checked wheel install works.
Also a non-blockable comment on uv:
Update .github/workflows/tests.yml Co-authored-by: qlrd <106913782+qlrd@users.noreply.github.com>
joaozinhom
force-pushed
the
pin_version
branch
from
October 27, 2026 17:15
b7286b7 to
e6a5066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to avoid or devs and contributors use exposed versions of our dependencies pos leak keys problem in CCA authority.