Skip to content

chore: updates to new release of krux-installer to get krux 26.09 - #307

Merged
qlrd merged 4 commits into
selfcustody:mainfrom
joaozinhom:newrelease/26.09
Oct 3, 2026
Merged

qlrd merged 4 commits into
selfcustody:mainfrom
joaozinhom:newrelease/26.09

Conversation

@joaozinhom

Copy link
Copy Markdown
Member

update docs, prebuild/fetch_firmware and constants/init.py file to be compliant with the new krux release and to we can launch the new release of the installer.

@joaozinhom

Copy link
Copy Markdown
Member Author

naturally the jobs will fail until we dont have the upstream lanched krux new release so this PR will wait for it and i will re run the jobs when its happen.

@joaozinhom
joaozinhom marked this pull request as draft September 2, 2026 13:07

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a old thing to be fixed

Comment thread pyproject.toml Outdated

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. once possible i go with ACK

@qlrd

qlrd commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Just thoughts, idk if reliable: a .firmware-version file on repo like thos .python-version used by uv? This way we just modify a 1 line file and not the script. cc @jdlcdl

@joaozinhom

Copy link
Copy Markdown
Member Author

Just thoughts, idk if reliable: a .firmware-version file on repo like thos .python-version used by uv? This way we just modify a 1 line file and not the script. cc @jdlcdl

could be nice but i think it will require a refact maybe an issue? and we catch it in the release after that one...

@qlrd

qlrd commented Sep 7, 2026

Copy link
Copy Markdown
Member

Just thoughts, idk if reliable: a .firmware-version file on repo like thos .python-version used by uv? This way we just modify a 1 line file and not the script. cc @jdlcdl

could be nice but i think it will require a refact maybe an issue? and we catch it in the release after that one...

idk as good first issue? so you could concentrate on essential stuffs

@joaozinhom

Copy link
Copy Markdown
Member Author

Just thoughts, idk if reliable: a .firmware-version file on repo like thos .python-version used by uv? This way we just modify a 1 line file and not the script. cc @jdlcdl

could be nice but i think it will require a refact maybe an issue? and we catch it in the release after that one...

idk as good first issue? so you could concentrate on essential stuffs

an normal issue you can assign it to me if you preffer i can take carry of it.

@qlrd

qlrd commented Sep 23, 2026

Copy link
Copy Markdown
Member

let's go boy

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 38fbaf1

@joaozinhom
joaozinhom marked this pull request as ready for review October 3, 2026 12:52
Comment thread prebuild/fetch_firmware.sh Outdated
qlrd and others added 2 commits October 3, 2026 12:03
This commit fixes a issue where in CI build it downloads correctly the
firwmare, but not the sha256 files and its signatures.
fix: use SHA256SUM file on 26.09
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (3afd2ff) to head (d2ba942).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   95.87%   96.10%   +0.22%     
==========================================
  Files          28       29       +1     
  Lines        1796     1927     +131     
  Branches      205      219      +14     
==========================================
+ Hits         1722     1852     +130     
- Misses         57       59       +2     
+ Partials       17       16       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This commit add details about how the new format on integrity and
authenticity files are being deal on both `selfcustody/krux` and
`selfcustody/krux-installer`.

Signed-off-by: qlrd <qlrddev@proton.me>
@qlrd
qlrd merged commit a8e92a9 into selfcustody:main Oct 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants