Skip to content

Fix nil return from SlideShare renderer causing NoMethodError#2635

Open
stuzart wants to merge 1 commit into
seek-1.18from
slideshare-renderer-error
Open

Fix nil return from SlideShare renderer causing NoMethodError#2635
stuzart wants to merge 1 commit into
seek-1.18from
slideshare-renderer-error

Conversation

@stuzart

@stuzart stuzart commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

Callers such as git/_blob.html.erb and raw_display.rb call .html_safe
directly on the render result, so nil would raise NoMethodError.
@stuzart stuzart added this to the 1.18.1 milestone Jun 23, 2026
@stuzart stuzart changed the base branch from main to seek-1.18 June 23, 2026 13:46
@stuzart stuzart moved this to In review in SEEK 1.18.x Jun 23, 2026
@stuzart stuzart requested a review from fbacall June 23, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Potential JSON parse error when rendering slideshare

2 participants