-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ add initial collaborate on GenomeDK section #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
signekb
wants to merge
7
commits into
main
Choose a base branch
from
feat/add-initial-collaborate-on-genomedk-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−154
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2c3c1d
style: :art: format `qmd`
signekb 1624d35
feat: :sparkles: add initial working in a shared folder on GenomeDK s…
signekb c654cee
fix: :pencil2: add missing anchor for outside genomedk header
signekb facc89d
Merge branch 'main' into feat/add-initial-collaborate-on-genomedk-sec…
signekb c877ded
fix: :pencil2: remove duplicate paragraph from merge
signekb e854a6d
Merge branch 'main' into feat/add-initial-collaborate-on-genomedk-sec…
signekb 8f9398f
docs: :memo: update collaborating section based on review
signekb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include a concrete folder structure here for "shared folder"? Are you working in the exactly the same folder? I made a comment or issue about this I thought, but I can't find it. Do you work like:
So you have a clone in
signe/and Marton works inmarton/? Or do you all work infeasibility-data/? If the second, we should probably work like the above to avoid this "shared editing" situation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, it's the second situation; there's one
feasibility-data/that everyone works in. With the first, you mean we each have a branch, or that we haven_users + 1clones of the repo (including the data)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We each have clones (with our name for the clone), where we all push and pull from GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we then only have the checked-out data files in the
main/repo? Otherwise, we would have multiple copies of the raw data - one copy for each local repo - right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be solved by using the build and release process I wrote about. No data is saved outside of the main repo on genomedk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I'll update this with my understanding of how we'll work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at this and wrote a comment.
Just two points here:
feasibility-data/folder, everyone can clone where they want. Or is there some benefit to having the clones in a shared folder?