Skip to content

fix(ci): provision config-keyring Secret before waiting on data-server-controller #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steiler wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

fix(ci): provision config-keyring Secret before waiting on data-server-controller #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/00-setup/02-artifacts.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,12 @@ Resource ../Keywords/k8s/kubectl.robot
Install SDCIO
kubectl apply ./config-server/artifacts/out/artifacts.yaml

Install CI keyring secret
[Documentation] config-server no longer ships a default config-keyring
... Secret in its own deploy artifacts (by design, to force real
... deployments to bring their own key material). The data-server
... StatefulSets mount this Secret as a volume regardless, so CI must
... provision its own throwaway key or the pods hang in
... ContainerCreating forever waiting for a Secret that never exists.
kubectl apply ./integration-tests/tests/00-setup/secret-config-keyring.yaml

18 changes: 18 additions & 0 deletions tests/00-setup/secret-config-keyring.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
apiVersion: v1
kind: Secret
metadata:
name: config-keyring
namespace: sdc-system
labels:
config.sdcio.dev/keyring: "true"
type: Opaque
stringData:
# CI-only placeholder key (same value as config-server's own placeholder
# sample, artifacts/in/secret_keyring.yaml). config-server intentionally
# stopped shipping a default keyring Secret in its own deploy artifacts
# (see sdcio/config-server commit 83d07f8, "added ENV keyring and removed
# keyring secret") so that real deployments are forced to provision their
# own key material instead of relying on a well-known default. The
# integration-tests cluster is not a real deployment, so it provisions its
# own throwaway key here.
keyring.json: '{"primary":"key-1","keys":{"key-1":"Fyap3X+pl8mYv2gV90sdmuy+YJ+FocFf5ygHGxZ+ws4="}}'