test: add target-discovery diagnostics on readiness timeout - #111
Closed
steiler wants to merge 1 commit into
Closed
Conversation
Wait Until Keyword Succeeds + Targets Check Ready fails with an opaque "1 != 0" when a Target never becomes ready, and gives no signal on whether the Target CR was ever created (discovery never found the device) versus created-but-not-ready. Add Wait Until Target Ready, dumping Target/DiscoveryRule state and api-server logs at WARN before failing, and switch all call sites to use it. No timeout/retry values changed. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets Check Readyfailures currently surface as an opaque1 != 0after a full 15-minuteWait Until Keyword Succeeds, with no signal on why — in particular no way to tell whether theTargetCR was never created (discovery never found the device) versus created-but-not-ready.Wait Until Target Readyintests/Keywords/targets.robot: same wait behavior, but on timeout it dumpsTarget/DiscoveryRulestate andapi-serverlogs atWARNbefore failing with a clear message.02-crud,03-deviations) to the new keyword. No timeout/retry values changed — this is diagnostics-only, not a behavior change.Split out of the
sensitivedata-server/config-server pairing (sdcio/data-server#460) investigation into recent SROSTargets Check Readytimeouts, so this can merge independently and unblock CI diagnostics for any other in-flight PR hitting the same timeout (e.g. sdcio/data-server#466).Note: an actual discovery-mechanism change (switching
sr2's DiscoveryRule from a/28prefix scan to address-based) was tried and reverted — per project docs, unreachable-target connection errors during range scanning are expected/by-design, so that change was not the right fix. This PR only adds visibility so the next occurrence is diagnosable.Test plan
robot --dryrunacross all 9 touched suites — 100/100 test cases pass (keyword resolution / imports valid)Targets Check Readytimes out againMade with Cursor