Temporary fix for ocnos

go.mod

@@ -3,6 +3,7 @@ module github.com/sdcio/data-server
 go 1.25.0
 
 replace github.com/openconfig/goyang v1.6.0 => github.com/sdcio/goyang v1.6.2-2
+replace github.com/scrapli/scrapligo => github.com/steiler/scrapligo v0.0.0-20260805094018-c96889d37120
 
 require (
 	github.com/AlekSi/pointer v1.2.0
@@ -116,3 +117,4 @@ require (
 	sigs.k8s.io/structured-merge-diff/v4 v4.4.3 // indirect
 	sigs.k8s.io/yaml v1.4.0 // indirect
 )
+

go.sum

@@ -181,8 +181,6 @@ github.com/prometheus/procfs v0.16.1/go.mod h1:teAbpZRB1iIAJYREa1LsoWUXykVXA1KlT
 github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
 github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
-github.com/scrapli/scrapligo v1.4.0 h1:gF7bIiRHT/aB1zTu9PYIK9R2A/gXr4fF/CKUyyWaNq4=
-github.com/scrapli/scrapligo v1.4.0/go.mod h1:pOWxVyPsQRrWTrkoSSDg05tjOqtWfLffAZtAsCc0w3M=
 github.com/sdcio/cache v0.0.38 h1:8meykZC/DAgzKI+R3GtZvTs0/OXWRCeNN5mxVKG0Ba8=
 github.com/sdcio/cache v0.0.38/go.mod h1:PHJd4pTmfFZBLdPohtXJAVBNmAKhhKdZHTi3MejGrk0=
 github.com/sdcio/goyang v1.6.2-2 h1:qfeUKBmoKpiKAruuEc3+V8wgHKP/n1jRDEnTy23knV8=
@@ -205,6 +203,8 @@ github.com/spf13/cobra v1.10.2/go.mod h1:7C1pvHqHw5A4vrJfjNwvOdzYu0Gml16OCs2GRiT
 github.com/spf13/pflag v1.0.9/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
 github.com/spf13/pflag v1.0.10 h1:4EBh2KAYBwaONj6b2Ye1GiHfwjqyROoF4RwYO+vPwFk=
 github.com/spf13/pflag v1.0.10/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
+github.com/steiler/scrapligo v0.0.0-20260805094018-c96889d37120 h1:bOazpNwMiFUpAtYcM7ucLsIYHHs6w9y62egMjZHuuB4=
+github.com/steiler/scrapligo v0.0.0-20260805094018-c96889d37120/go.mod h1:pOWxVyPsQRrWTrkoSSDg05tjOqtWfLffAZtAsCc0w3M=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/objx v0.1.1/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=

pkg/datastore/target/netconf/sync.go

@@ -70,7 +70,12 @@ func (s *NetconfSyncImpl) Start() error {
 		return nil
 	}
 
-	go func() { _ = s.internalSync(req) }()
+	go func() {
+		err = s.internalSync(req)
+		if err != nil {
+			log.Error(err, "failed syncing")
+		}
+	}()
 
 	go func() {
 		ticker := time.NewTicker(s.config.Interval)

pkg/tree/ops/utils.go

@@ -22,6 +22,14 @@ func getListEntrySortFunc(parent api.Entry) func(a, b api.Entry) int {
 			aLvSlice := GetHighestPrecedence(achild, false, true, true)
 			bLvSlice := GetHighestPrecedence(bchild, false, true, true)
 
+			// A key leaf can legitimately end up without any LeafVariant (e.g. a
+			// structural/placeholder entry created while navigating the tree without
+			// a value ever being set for it). We cannot compare such entries, so treat
+			// them as equal on this key, just like the "doesn't exist" case above.
+			if len(aLvSlice) == 0 || len(bLvSlice) == 0 {
+				return 0
+			}
+
 			aEntry := aLvSlice[0]
 			bEntry := bLvSlice[0]
 

pkg/tree/ops/utils_test.go

@@ -0,0 +1,67 @@
+package ops_test
+
+import (
+	"context"
+	"runtime"
+	"testing"
+
+	"github.com/sdcio/data-server/pkg/pool"
+	"github.com/sdcio/data-server/pkg/tree"
+	"github.com/sdcio/data-server/pkg/tree/api"
+	"github.com/sdcio/data-server/pkg/tree/ops"
+	"github.com/sdcio/data-server/pkg/utils/testhelper"
+	sdcpb "github.com/sdcio/sdc-protos/sdcpb"
+	"go.uber.org/mock/gomock"
+)
+
+// TestToJson_ListEntryKeyWithoutLeafVariant reproduces a panic scenario where a
+// list entry's key leaf exists in the tree (e.g. as a structural/placeholder
+// entry created while navigating the tree) but never got a LeafVariant assigned
+// to it and has no active children either. Sorting such list entries for JSON
+// rendering used to index into an empty slice returned by GetHighestPrecedence,
+// causing an "index out of range [0] with length 0" panic. ToJson must instead
+// treat such incomparable entries as equal and render without panicking.
+func TestToJson_ListEntryKeyWithoutLeafVariant(t *testing.T) {
+	mockCtrl := gomock.NewController(t)
+	defer mockCtrl.Finish()
+
+	scb, err := testhelper.GetSchemaClientBound(t, mockCtrl)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	ctx := context.Background()
+	tc := tree.NewTreeContext(scb, pool.NewSharedTaskPool(ctx, runtime.GOMAXPROCS(0)))
+	root, err := tree.NewTreeRoot(ctx, tc)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	// Create two list entries purely via structural navigation (no updates / no
+	// LeafVariants applied), leaving the "name" key entries valueless, similar to
+	// how a placeholder path can end up in the tree without ever carrying data.
+	for _, name := range []string{"ethernet-1/1", "ethernet-1/2"} {
+		keyNode, err := ops.GetOrCreateChilds(ctx, root.Entry, &sdcpb.Path{
+			Elem: []*sdcpb.PathElem{
+				sdcpb.NewPathElem("interface", map[string]string{"name": name}),
+			},
+		})
+		if err != nil {
+			t.Fatal(err)
+		}
+		// Attach the "name" key leaf entry structurally, without ever adding a
+		// LeafVariant to it.
+		if _, err := api.NewEntry(ctx, keyNode, "name", tc); err != nil {
+			t.Fatal(err)
+		}
+	}
+
+	if err := root.FinishInsertionPhase(ctx); err != nil {
+		t.Fatal(err)
+	}
+
+	// Must not panic.
+	if _, err := ops.ToJson(ctx, root.Entry, false); err != nil {
+		t.Fatalf("ToJson() returned unexpected error: %v", err)
+	}
+}