Repository navigation
parity_suite.sh: run on macOS, and flag runs that read no reads - #369
Open
BenjaminDEMAILLE wants to merge 1 commit into
Open
BenjaminDEMAILLE wants to merge 1 commit into
BenjaminDEMAILLE wants to merge 1 commit into
Conversation
On macOS the suite could not produce a single real comparison: /usr/bin/time has no -f, `wc -l` pads its count so the chr21 download check always failed, and `--readFilesCommand zcat` reads only .Z files there, so STAR and rustar-aligner both read 0 reads, exited 0, and compared as identical. Timing now goes through Python's resource module (same "seconds KB" file), the count is trimmed, and gzcat is used where it exists. parity_compare.py warns when a tool read 0 reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #354 (
test/parity_suite.shon macOS).Problem
On macOS,
test/parity_suite.shcannot produce one real comparison, and it does not say so.timedcalls/usr/bin/time -f "%e %M". macOS'stimehas no-f, so every index build and alignment is reported as failed."$(gunzip -c … | wc -l)" = 8000000. macOS'swcpads the count with spaces, so a complete 8,000,000-line file is reported asdownload incompleteandfetchstops.--readFilesCommand zcat. On macOS,zcatis thecompressone: it only reads.Zfiles. STAR and rustar-aligner both read 0 reads, exit 0, andparity_compare.pyprintsrecords 0/0, identical 0 … Log.final.out: identicalfor all 21 configurations.The last one is the dangerous part. I ran the suite on macOS this way first: every configuration "matched".
Change
timedruns the command through a few lines of Python (resource.getrusage(RUSAGE_CHILDREN)), and writes the sameseconds KBfile thatparity_compare.pyreads.ru_maxrssis in bytes on macOS and KB on Linux; the script converts.wc -lcount goes throughtr -d " ".ZCAT=$(command -v gzcat || echo zcat):gzcaton macOS,zcaton Linux. It stays one word, becausemainstill takes one word for--readFilesCommand(--readFilesCommand takes what STAR takes #353 changes that).parity_compare.pyprints aWARNINGwhen either tool'sLog.final.outreports 0 input reads.geneInfo.tabwith--quantModeor--soloType. From STAR's source, that comes from the build, not from the options:Transcriptome.cpp:13readstrInfoDirfromsjdbInsert.outDir, which is empty, whileGenome_genomeLoad.cpploads the index parameters into a separateP1. A Linux build of the same 2.7.11b source runs them. I did not dig further into the Homebrew build.Measured
macOS (Apple silicon), Homebrew STAR 2.7.11b for alignment and a Linux (Docker, arm64) build of the 2.7.11b source for the quant and solo configurations,
mainat 32fbbc1:fetchERR188021_1: download incompletey10k_sen/aWARNING: rustar-aligner read 0 reads; check --readFilesCommand (y10k_se)With these changes the whole suite reproduced the README's comparison on macOS: yeast 0 differing reads in every configuration (1 in
y100k_pe_attr), chr21 PE 3, fusion 24, solo default 36/36 files identical. The only new observation is inLog.final.outon yeast PE: 15,208 "too short" and 26 "other" for STAR against 15,209 and 25, which the README does not mention.Tests
None added: this is test tooling. The timing helper was checked on a 50 MB allocation (61,792 KB reported) and on a failing command (exit code passed through), and
bash -npasses.Not checked
time's output format and fall back tozcat, but I did not rerun the suite on Linux.🤖 Generated with Claude Code