Repository navigation
fix(solo): port STAR's cbMinP, QSmax and oneExact for 1MM_multi barcode correction - #274
Open
BenjaminDEMAILLE wants to merge 1 commit into
Open
BenjaminDEMAILLE wants to merge 1 commit into
BenjaminDEMAILLE wants to merge 1 commit into
Conversation
--soloCBmatchWLtype 1MM_multi_Nbase_pseudocounts behaved like 1MM_multi: the posterior threshold (cbMinP 0.975, single precision), the quality cap (QSmax 33) and the oneExact gate for non-pseudocount match types were missing. Includes the fixture from #243 plus two tests that fail without the fix. Refs #172 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #172.
--soloCBmatchWLtype 1MM_multi_Nbase_pseudocountsbehaved like1MM_multibecause three pieces of STAR (SoloReadFeature_inputRecords.cpp,ParametersSolo.cpp) were missing:cbMinP= 0.975: the winner needs 97.5% of the summed posterior (single precision, as STAR).QSmax= 33: mismatch quality capped before the posterior.oneExact: for non-pseudocount types, a barcode corrected to a single whitelist entry is dropped unless some read matched it exactly.--soloUMIfiltering MultiGeneUMI_CRis already live on main (#173) and untouched.Includes #243's
tests/solo_cellranger_flags.rsplus two tests comparing against1MM_multithat fail without the fix.Supersedes the
cbMinP/oneExactpart of #165 (itsoneExactsits in a branch that never triggers); the two will conflict inresolve_multi_cband CHANGELOG.Not done: the 8.9% matrix gap was not re-measured (needs STAR + the 20k-read fixture). Known remaining gaps:
CellReads.statsstill counts reads later dropped byoneExact; Transcript3p records aren't filtered byoneExact.Tests: fmt, clippy 0 warnings, all test binaries pass.
🤖 Generated with Claude Code